feat: tolerate failed checkins / ready #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redref
force-pushed
the
feat/ready_tolerate
branch
3 times, most recently
from
00fb796 to
155f8b6
Compare
redref
force-pushed
the
feat/ready_tolerate
branch
6 times, most recently
from
a58ae4d to
0aceab3
Compare
Making checkin process optional (default to activated)
redref
force-pushed
the
feat/ready_tolerate
branch
from
0aceab3 to
69453ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/kilnfi/kilo/blob/main/pkg/mesh/backend.go#L88
If network goes south, node(s) would be unready in the backend (k8s cache informer), explaining why wireguard conf is cleaned.
That should also stabilize network by limiting update in k8s api.